Yandere Simulator Complete Source Code Analysis - Code Review

CORRECTION: The sqrt instruction does not take 1 clock cycle. More like 20-60. It's still pretty fast though, and we don't have to check for distances often enough that this matters. CORRECTION: Combining meshes does not necessarily reduce draw calls. I think Unity does it to improve load times. SO WHY IS THE GAME SLOW? See: youtube.com/post/UgwqYKf598HtLsnKV314AaABCQ I'm sorry for all the mic popping. :( Tried to fix it in post as much as possible, but we couldn't get all of it. About drawcalls: Unfortunately, Unity's frame debugger does not work on linux. However, pointing the camera at all the students causes the game to render about 2 million triangles, and looking away makes the game render about 200k triangles. Don't need the frame debugger to deduce the problem here. Apparently there is a lot I don't know about graphics engineering. Sounds like a good topic for another video.... UPDATE: I took a very brief look at the frame debugger on windows, and it pretty clearly explains why looking at students decreases the framerate so much. Here's a summary of what I found: - Students are drawn twice, using 2 different shaders, one without the toon outline, and one with the toon outline. - The student's irises have their own draw calls. Some irises have little shines in them, which are on another iris mesh, with their own draw call. - Each modular part of each student has it's own draw call. I've been working with Yandere Dev to optimize the game and bring the framerate up.

I find it hilarious that the biggest file in the game is a model of a toothbrush that he just bought from an asset store and never noticed that it has polygons for every individual bristle.

My man be lookin like coraline's dad.

Yandere's code can turn out to have educational value. His code should be on exams or homeworks and ask students to identify the problems

"Inconsistent use of tabs and spaces" "F-ing pick one" I felt that

"If he spent another hour on [this], it would have potentially saved him a couple years of grief." That's it, that's the game in a nutshell.

Me who doesn't know anything about coding: "Yeah, you're perfectly right."

I’m a senior software engineer, so I feel qualified to say this video is very, very good. It really scratches the itch I have for technical deep dives that are actually entertaining. This video has the quality of video essayists with millions of subs and the code review quality is better than anything I’ve seen in a professional environment. I’ll be sticking around even if I have to wait months between videos.

“don’t decompile my code” “Ok, I’ll do it while you don’t watch

'sort of implied that he didn't want me to do it' 'so I did it anyway' You mad lad

I can not stop laughing over the irony that one of the reasons people complain about framerate..... is that yanderedev implemented the framerate display so poorly that it displays lower frames than it actually has. (48:50)

"The compiler is smarter than you." As an experienced software architect with decades of experience in this, you are 100% correct. I've only met a small number of people who could confidently claim to be smarter than a modern compiler (the compiler design professor at University, for one), but even he touts that modern compilers are so advanced that these minute optimizations are unnecessary. Make it work. Make it fast. In that order.

This guy turned up, made a single million view video, then left. Absolute fucking hero.

I don't understand 80% of what you're saying, but I deeply appreciate the polished visuals and editing, your natural charisma and calming voice, and how comprehensive I have to assume all of this is. I didn't even realize I had watched the entire thing until it was nearly done.

"a dark magic ritual known only to the compiler gods" so like building any cmake project

I liked your take on how everyone suggests converting the else ifs into switch statements. The problem isn't the style of large conditional statements, the problem is large conditional statements.

"The compiler is smarter than you." Completely valid statement.

Finally a real analysis of the whole thing! Not just "IF-ELSE bad, SWITCH good!!!"

yo your music slaps, didn't realize you made all of it yourself

Holy shit where did you COME FROM!? An hour of A1 editing, incredibly understandable concept presentation, insane amounts of knowledge/info on both Unity and computer science in general. This is crazy. This video has like several years worth of game dev knowledge/analytics shoved into it. You have under 100k subs, 2 videos, like what the hellll?!?! Your transition materials and songs are fucking well-found too. I don't understand where you came from bro, this is nuts.